Wrap all comments to 100 characters. Add a lint for long comments. #4263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also configures `rustfmt` to 100 character `max_width`, which only impacts code reflows, and isn't a hard limit. But here in this change, I'm only worried about comments. Fix #4262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also configures
rustfmtto 100 charactermax_width, which only impacts code reflows, and isn't a hard limit. But here in this change, I'm only worried about comments.Fix #4262
NOTE: This will conflict all over the place with #4219, which I totally know and understand, but most of it won't, and I am gonna rebase it afterward. But I just had a little more steam left tonight and wanted to bang this out.