Fix duplicate light-curve method and restore download error handling#377
Open
emmanuel-ferdman wants to merge 1 commit intodiwas7777:mainfrom
Open
Fix duplicate light-curve method and restore download error handling#377emmanuel-ferdman wants to merge 1 commit intodiwas7777:mainfrom
emmanuel-ferdman wants to merge 1 commit intodiwas7777:mainfrom
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
Author
|
@Aesthetic99 could you please review this really small PR when you get the chance? thank you 🙌 |
Contributor
|
Reviewed |
Aesthetic99
approved these changes
Nov 18, 2025
Author
|
@Aesthetic99 Thanks for the review. I see from a previous PR that you have push permissions, so I'm asking for your guidance: is there anything else needed from my side? If you'd rather not merge it yourself, could you please tag a maintainer? |
Aesthetic99
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This small PR Fixes the duplicate
analyze_light_curvedefinition introduced in the PR #336 by keeping the enhanced signature withheight_thresholdand reinstating a clear exception message when the light curve download fails.