Removed redundant mode switch rotation, cleaned up warnings and dead code. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(before anything but low would keep rotating, now it rotates once by state change) Added README with help how to build
…nnel. See README for more details.
This allows using the APM mode switch as a normal channel rotation switch just like you'd use a 3 position switch.
Fixed all C++ warnings in arduino 1.0.6 Removed other unused variables. Freed up 188 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dead code without removing functionality (except for mode switch OSD rotation should be done by using channel rotation switching, which now works both with MS and with switches, saves some code).
Other code savings (188 bytes) and fixed all C++ warnings.
This was tested on the bench, but not flight tested. I did not provide a precompiled binary as I consider version 808 developer only (807 has new functionality for users and I gave a binary for that).