Skip to content

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Aug 6, 2025

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Enhancements:

  • Drop LooseVersion import and DJANGO_2_2 flag from utils and fields modules

Copy link
Contributor

sourcery-ai bot commented Aug 6, 2025

Reviewer's Guide

The PR eliminates the deprecated distutils.LooseVersion import and associated DJANGO_2_2 compatibility flag, cleaning up unused code across the utils and fields modules.

Class diagram for removal of DJANGO_2_2 and LooseVersion references

classDiagram
    class utils {
        - DJANGO_VERSION : str
        - PYTHON_VERSION : str
    }
    %% Note: DJANGO_2_2 and LooseVersion have been removed from utils

    class fields {
        +regex_key_validator
        %% No longer imports DJANGO_2_2 from utils
    }
    utils <.. fields : import (DJANGO_2_2 removed)
Loading

File-Level Changes

Change Details Files
Remove distutils.LooseVersion usage and DJANGO_2_2 constant
  • Deleted import of LooseVersion
  • Removed DJANGO_2_2 computation and related comments
djangocms_attributes_field/utils.py
Drop unused DJANGO_2_2 import in fields module
  • Removed import of DJANGO_2_2 from utils
djangocms_attributes_field/fields.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (41d95f8) to head (ffe6bf0).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   91.44%   89.13%   -2.32%     
==========================================
  Files           4        4              
  Lines         187      184       -3     
  Branches       29       29              
==========================================
- Hits          171      164       -7     
- Misses         10       14       +4     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fsbraun fsbraun merged commit a0fb569 into master Aug 6, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant