-
Notifications
You must be signed in to change notification settings - Fork 17
fix: Remove reference to sunset LooseVersion of distutils #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThe PR eliminates the deprecated distutils.LooseVersion import and associated DJANGO_2_2 compatibility flag, cleaning up unused code across the utils and fields modules. Class diagram for removal of DJANGO_2_2 and LooseVersion referencesclassDiagram
class utils {
- DJANGO_VERSION : str
- PYTHON_VERSION : str
}
%% Note: DJANGO_2_2 and LooseVersion have been removed from utils
class fields {
+regex_key_validator
%% No longer imports DJANGO_2_2 from utils
}
utils <.. fields : import (DJANGO_2_2 removed)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 91.44% 89.13% -2.32%
==========================================
Files 4 4
Lines 187 184 -3
Branches 29 29
==========================================
- Hits 171 164 -7
- Misses 10 14 +4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.
Summary by Sourcery
Enhancements: