chore: improve code quality and repository standards#4
Merged
Conversation
- Add .gitignore
There was a problem hiding this comment.
Code Review
This pull request introduces a new .gitignore file to manage project dependencies, build outputs, and environment-specific files. Feedback suggests expanding the Python ignore patterns to include individual compiled files and adding common certificate and private key extensions to prevent accidental security leaks.
| @@ -0,0 +1,30 @@ | |||
| # Dependencies | |||
| node_modules/ | |||
| __pycache__/ | |||
Comment on lines
+13
to
+15
| .env | ||
| .env.local | ||
| .env.*.local |
There was a problem hiding this comment.
Given the project's focus on government standards and authentication (e.g., PKIoverheid, DigiD), it is a critical security practice to prevent accidental commits of private keys or certificates. Adding common extensions like .pem, .key, .p12, and .pfx to the ignore list helps mitigate this risk.
.env
.env.local
.env.*.local
*.pem
*.key
*.p12
*.pfx
References
- Preventing the accidental commitment of sensitive information such as private keys and environment variables is a fundamental security requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
Auto-generated by code quality scanner.