Skip to content

chore: improve code quality and repository standards#4

Merged
djimit merged 1 commit into
mainfrom
chore/code-quality-improvements
May 3, 2026
Merged

chore: improve code quality and repository standards#4
djimit merged 1 commit into
mainfrom
chore/code-quality-improvements

Conversation

@djimit

@djimit djimit commented May 3, 2026

Copy link
Copy Markdown
Owner

This PR adds:

  • Add .gitignore

Auto-generated by code quality scanner.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new .gitignore file to manage project dependencies, build outputs, and environment-specific files. Feedback suggests expanding the Python ignore patterns to include individual compiled files and adding common certificate and private key extensions to prevent accidental security leaks.

Comment thread .gitignore
@@ -0,0 +1,30 @@
# Dependencies
node_modules/
__pycache__/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is recommended to also ignore individual compiled Python files (*.pyc, *.pyo, *.pyd) to ensure the repository remains clean across different environments, even if files are generated outside of the __pycache__ directory.

__pycache__/
*.py[cod]
*$py.class

Comment thread .gitignore
Comment on lines +13 to +15
.env
.env.local
.env.*.local

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Given the project's focus on government standards and authentication (e.g., PKIoverheid, DigiD), it is a critical security practice to prevent accidental commits of private keys or certificates. Adding common extensions like .pem, .key, .p12, and .pfx to the ignore list helps mitigate this risk.

.env
.env.local
.env.*.local
*.pem
*.key
*.p12
*.pfx
References
  1. Preventing the accidental commitment of sensitive information such as private keys and environment variables is a fundamental security requirement.

@djimit djimit merged commit 9babc66 into main May 3, 2026
1 check passed
@djimit djimit deleted the chore/code-quality-improvements branch May 3, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant