Added ThreadPool #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzharkov
suggested changes
Apr 30, 2018
ThreadPool/.idea/compiler.xml
Outdated
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
В чем смысл хранения .idea в репозитории для гредл проекта? Пока -2
| private void compute() { | ||
| try { | ||
| result = supplier.get(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Почему именно Exception, а не Throwable?
| */ | ||
| @Override | ||
| public <U> LightFuture<U> thenApply(Function<T, U> function) { | ||
| return addTask(() -> function.apply(get())); |
There was a problem hiding this comment.
" Метод thenApply не должен блокировать работу потока, если результат задачи X ещё не вычислен", -1
There was a problem hiding this comment.
Нужно добавить тест, который это проверяет
| workers = new Thread[poolSize]; | ||
|
|
||
| Runnable workerRunnable = () -> { | ||
| LightFutureImpl<?> future; |
There was a problem hiding this comment.
Я бы вынес тело Runnable в отдельный метод для улучшения читаемости
| * Shuts down all of its current workers. | ||
| */ | ||
| @Override | ||
| public void shutdown() { |
There was a problem hiding this comment.
Мне кажется, метод shutdown должен завершаться только после завершения всех потоков. -1
| } | ||
| } | ||
|
|
||
| public ThreadPoolImpl(int poolSize) { |
There was a problem hiding this comment.
Обычно поля и конструктор класса размещают в начале
|
Ок, 10/10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.