Added MD5 #4
Open
Added MD5 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 13, 2018 17:50
dzharkov
reviewed
May 2, 2018
| long endSingleTime = System.nanoTime(); | ||
| long startMultiTime = System.nanoTime(); | ||
| try { | ||
| hashSingleThread(root); |
There was a problem hiding this comment.
Извиняюсь, за занудство, но тут не тот метод явно.
С одной стороны это простая человеческая невнимательность и можно было бы понять, но это показывает, что вы не задались вопросом, почему разницы по времени нет. -1
| List<HashRecursiveTask> tasks = new LinkedList<>(); | ||
| for (File content : contents) { | ||
| HashRecursiveTask task = new HashRecursiveTask(content); | ||
| task.fork(); |
There was a problem hiding this comment.
В этот момент таска уходит на дефолтный fork-join pool. А это вряд ли то, что здесь ожидалось, учитывая, что выше вы создаете свой тред-пул. -1
|
Итого: 9/10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.