Simple ftpgui #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzharkov
reviewed
May 30, 2018
dzharkov
left a comment
dzharkov
left a comment
There was a problem hiding this comment.
Текущая оценка: 7.5
Макс. оценка: 8.5
| System.out.println("No such file"); | ||
| return; | ||
| } | ||
| try (FileOutputStream out = new FileOutputStream(name)) { |
There was a problem hiding this comment.
Опять ручная манипуляция байтовыми массивами, -1
| } | ||
|
|
||
| private FolderDescription requestFolderDescription(String name) { | ||
| System.out.println("1 " + name); |
There was a problem hiding this comment.
Давайте убирать перед проверкой логгирование. -0.5
| } | ||
|
|
||
| private static String getNewPath(String path, String name) { | ||
| if (path.equals("./")) { |
There was a problem hiding this comment.
Меня смущает, что используется много магических path-related констант.
Пока -1, надо переписать так, чтобы получилось ОС и ФС независимо
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.