Skip to content

Conversation

@dkaznacheev
Copy link
Owner

No description provided.

Copy link

@dzharkov dzharkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок, 8/10



public class TestExecutionResult {
private String failMessage;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final? -1

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил


public class TestExecutionInfo {

public final long time;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс без геттеров. -1

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Скажите, пожалуйста, почему 8/10? Это были вычитания баллов из максимального?

@dzharkov
Copy link

Да, про инкапсуляцию и final поля, как я понял, вас предупреждали

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants