Logo arcade #6
Logo arcade #6
Conversation
sirin_arcades/clients/ui/src/main.c
Outdated
| { | ||
| return 1; | ||
| } | ||
| static bool receive_message(void *busclientconnection) { |
sirin_arcades/clients/ui/src/main.c
Outdated
| return 1; | ||
| } | ||
| static bool receive_message(void *busclientconnection) { | ||
| SoToClient received_message; |
| return result; | ||
| } | ||
|
|
||
| int iteration = 0; |
There was a problem hiding this comment.
why iteration not in game_frame as static
There was a problem hiding this comment.
is is also used in add_random_logo_pixels_changes function
There was a problem hiding this comment.
There is only one reason to have global var, it's when you want to store context for user but you don't want to malloc. It's not a case
|
|
||
| bool is_client_id = false; | ||
| int find_random_k(int n) { | ||
| srand(time(NULL)); |
| printf(", "); | ||
| char logo[][96] = { | ||
| #include "logo.txt" | ||
| }; |
There was a problem hiding this comment.
Split with enters differen blocks
| SoToServerTransitBack *global_array = NULL; | ||
| size_t global_array_capacity = 0; | ||
| size_t global_array_length = 0; |
There was a problem hiding this comment.
Why you don't use vector here????
There was a problem hiding this comment.
array must be deallocated at the end, idk how to achieve this
There was a problem hiding this comment.
vec->append(vec, &ch, sizeof(char));
vec->release(vec);
return vec->buffer;You may return buffer from vector and also from vector get size
There was a problem hiding this comment.
I didn't get deallocation idea if you release you will rewrite the data. Anyway It should be done with vector. Please figure out
| int temp; | ||
| while (b != 0) |
sirin_arcades/clients/ui/src/main.c
Outdated
|
|
||
| int yeah = 0; | ||
| switch (received_message.tag) { | ||
| case DrawPixel: |
There was a problem hiding this comment.
Don't use tabs use 4 spaces instead
(In Makefiles tabs are fine) Fix all C and Rust
sirin_arcades/clients/ui/src/main.c
Outdated
| received_message.draw_pixel.x, | ||
| received_message.draw_pixel.pixel_t.color_pair_id, | ||
| received_message.draw_pixel.pixel_t.character | ||
| ); |
| } | ||
| } | ||
| static int x = 0; | ||
| static int starting_num = 0; // має бути тей що і x |
| .character = ch, | ||
| .color_pair_id = RANDOM_COLOR_PAIR |
| eprintln!("promises are broken. (format must be like 131;112;). BUT YOU GAVE THIS ABOMINATION {:?}", buf.as_slice()); | ||
| return null_mut(); | ||
| } | ||
| let got_width = i32::from_be_bytes([buf[0], buf[1], buf[2], buf[3]]); // потенційно зберігти отримане для подальшого оффсету |
| @@ -5,28 +5,27 @@ | |||
|
|
|||
| #include <events_bus.h> | |||
|
|
|||
|
|
|||
| SoToServerTransitBack *global_array = NULL; | |||
| size_t global_array_capacity = 0; | |||
| size_t global_array_length = 0; | |||
No description provided.