Skip to content

WebSockets support #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

mmitkevich
Copy link

New features:

  • SslSocket
  • WebSocket
  • StringTable
  • Url

Optimizations and bug fixes:

  • less gc in logger
  • compatibility with fiber oblivious invocation(crash in poller.d)

@jacob-carlborg
Copy link
Collaborator

This is really interesting. I wanted to implement websockets in Mecca myself, but now I don't have to 😃.

@mmitkevich
Copy link
Author

I'm interested in implementing HttpSocket with get/post/put and Socks proxy support. If you wish to collaborate on this we could extract WebSocket into separate repo since no interest in merging this stuff into mecca so far.

@jacob-carlborg
Copy link
Collaborator

jacob-carlborg commented Aug 7, 2019

That's sounds interesting, I wanted to do that as well. Currently I don't have much time available and I shouldn't really start yet another new project. I will most likely use something else than Mecca for the application I want to build. I really like to make progress on the actual application instead of working on libraries.

I recommend you start a separate project, I've already done that [1]. The guys working on Mecca are really busy. It took 5-6 months for my PR [1] which implemented support for macOS to be merged.

I've also started looking into using an existing HTTP parse written in C.

I really would like to get involved but I don't know how much time I can spend.

[1] https://github.com/jacob-carlborg/mecca-http
[2] #12

@Shachar
Copy link
Contributor

Shachar commented Aug 7, 2019

I'm interested in implementing HttpSocket with get/post/put and Socks proxy support. If you wish to collaborate on this we could extract WebSocket into separate repo since no interest in merging this stuff into mecca so far.

I have pretty much moved on, and Eyal has no time at all. I believe it is not a lack of interest as it is a lack of time.

With that said, my vision for Mecca when I started was not for it to contain HTTP support, but for it to allow HTTP support to be written as an external library. As such, your idea to write it as a separate library seems correct to me.

If you do, I'm sure we could get Eyal to add a link to it from Mecca proper (I no longer have commit access).

@Shachar
Copy link
Contributor

Shachar commented Aug 7, 2019

With that said, some of your commits seem to be extending infra already in mecca. It would make sense to merge those rather than duplicate.

@jacob-carlborg
Copy link
Collaborator

@mmitkevich are you on Slack?

@mmitkevich
Copy link
Author

@jacob-carlborg Yes I use it. Some particular link to your workspace?

@PetarKirov
Copy link
Member

https://dlang.slack.com

@jacob-carlborg
Copy link
Collaborator

There’s dlang.slack.com.

@mmitkevich
Copy link
Author

@jacob-carlborg No, not on that workspace. Could someone send me invitation to mikhail DOT mitkevich AT gmail.com please?

@jacob-carlborg
Copy link
Collaborator

I asked the admin to send an invite.

@jacob-carlborg
Copy link
Collaborator

I’ve sent an invite now.

@baruch
Copy link
Collaborator

baruch commented Oct 13, 2019

Hello @mmitkevich, I'm taking over the maintenance of mecca in Weka, as Shachar suggested, the WebSockets part should be in its own library, and we'll be happy to link to mecca related packages. The parts that are touching the mecca internals should be submitted in another PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants