-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio Project for the runtime #20783 #20837
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @12345swordy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20837" |
I feel like this is liable to get out of sync as files are added and moved around. |
dmd.vcxproj uses the deprecated, but still functional source globbing version:
That hasn't broken for years AFAICT. You must edit the project in a text editor, though, as saving it from within VS wrecks that. I would not add a new directory just for the new project, add druntime.vcxproj along side dmd.vcxproj. |
I suspect you will need some msbuild-magic to switch the compiler from the dmd-project to be used for building druntime. Any other compiler is not guaranteed to be in sync and might not be able to compile the current version of druntime. |
@rainers I can't find the ability to override the default path of the dmd compiler anywhere in visual d here. |
I think you should be able to replace the path to dmd.exe with something like
somewhere after the eraly imports. |
@rainers Ok! Its officially done! It builds using the generated dmd executable per requested. |
@rainers @thewilsonator
Ok I got the basics done, it builds the library solution successfully. Let me know if there anything else that the solution should do.
Fixes #20783