-
-
Notifications
You must be signed in to change notification settings - Fork 745
Added nothrow @nogc @safe to the allocate function. #10780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request and interest in making D better, @George-Alex-Berea! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10780" |
teodutu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edi33416 if you remember any of this from ages ago, please add your review as it revives your work.
|
@andralex can you please take a look? |
|
looking good! |
|
Should something more be done to get this PR merged? |
|
No, I just need to take a good close look at those |
|
Ok, thanks! |
|
CC @teodutu please re-review |
teodutu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking fine now. Thanks @George-Alex-Berea.
Also added these flags to all the functons it calls.
In order to make the functions safe I isolated the 'unsafe' parts inside @trusted lambda expressions, inspired by edi33416's pull request #6416.
Additionally, added nothrow @nogc @safe to the allocateAll function, since it only calls allocate.