Fixed version check from working in inverse, as it is: !(x < 3.6)#81
Open
JkktBkkt wants to merge 1 commit intodlenski:masterfrom
Open
Fixed version check from working in inverse, as it is: !(x < 3.6)#81JkktBkkt wants to merge 1 commit intodlenski:masterfrom
JkktBkkt wants to merge 1 commit intodlenski:masterfrom
Conversation
… then not'ing the result of the check. Current version was: if not sys.version_info < (3, 6) -> exit let's test this: Ex. 1 sys.version_info = (3, 5) sys.version_info < (3, 6) ? true not sys.version_info < (3, 6) ? false -> try continuing the installation as normal Ex. 2 sys.version_info = (3, 10) sys.version_info < (3, 6) ? false not sys.version_info < (3, 6) ? true -> exit, error message "Python 3.6 or newer is required" If 3.6 or newer is required, the 'not' in the check is breaking it. Admittedly, most users probably stay on the release version. Still, this shouldn't be so obviously and easily fixable imo.
|
fixes #77 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version was:
if not sys.version_info < (3, 6) -> exit
let's test this:
Ex. 1
sys.version_info = (3, 5)
sys.version_info < (3, 6) ? true
not sys.version_info < (3, 6) ? false -> try continuing the installation as normal
Ex. 2
sys.version_info = (3, 10)
sys.version_info < (3, 6) ? false
not sys.version_info < (3, 6) ? true -> exit, error message "Python 3.6 or newer is required"
If 3.6 or newer is required, the 'not' in the check is breaking it. Admittedly, most users probably stay on the release version. Still, this shouldn't be so obviously and easily fixable imo.