Skip to content

Fix for SourceComments including stdin instead of proper file path#286

Open
aphex wants to merge 2 commits into
dlmanning:masterfrom
aphex:master
Open

Fix for SourceComments including stdin instead of proper file path#286
aphex wants to merge 2 commits into
dlmanning:masterfrom
aphex:master

Conversation

@aphex

@aphex aphex commented May 25, 2015

Copy link
Copy Markdown

Resolves #234

@Keats

Keats commented Jun 9, 2015

Copy link
Copy Markdown
Collaborator

sorry for the wait, could you add a test that was previously failing for that to the testsuite?

@Snugug

Snugug commented Jun 24, 2015

Copy link
Copy Markdown
Collaborator

Yes, please add a test for this.

I'm also concerned that passing the file to Node Sass may result in unintended consequences of the raw file being compiled instead of the contents of the file stream. We already have a place in our codebase to transform stdin in to the main file's path (for sourcemaps); please refer to that,

@Snugug Snugug added this to the 2.1.0 milestone Jun 24, 2015
@Snugug

Snugug commented Jul 14, 2015

Copy link
Copy Markdown
Collaborator

With the fix in #314, this is now failing. Can you please update?

@xzyfer xzyfer force-pushed the master branch 13 times, most recently from 5c3ead2 to cc4ed2f Compare March 11, 2018 05:37
@XhmikosR

XhmikosR commented Dec 29, 2021

Copy link
Copy Markdown
Contributor

@xzyfer are you still interested in this? I rebased it, but unsure if you want to land it: master...XhmikosR:pr/286

@XhmikosR XhmikosR mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sourceComments option gets ignored if called by gulp.watch

4 participants