Skip to content

Pass along sass's stats object#808

Open
WraithKenny wants to merge 1 commit into
dlmanning:masterfrom
WraithKenny:master
Open

Pass along sass's stats object#808
WraithKenny wants to merge 1 commit into
dlmanning:masterfrom
WraithKenny:master

Conversation

@WraithKenny

Copy link
Copy Markdown
Contributor

The stats object that's returned from the sass compiler contains some interesting info, particularly includedFiles which can be used to develop smarter watchers. Related to #279, fixed #428

The `stats` object that's returned from the sass compiler contains some interesting info, particularly `includedFiles` which can be used to develop smarter watchers. Related to dlmanning#279, fixed dlmanning#428
@WraithKenny

Copy link
Copy Markdown
Contributor Author

I named the property sassStats instead of stats to avoid confusion or potential collision.

@niksy

niksy commented Sep 7, 2021

Copy link
Copy Markdown

What can we do to get this merged? This would definitely help in creating smarter watchers.

@XhmikosR

XhmikosR commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

I think if you extended the tests to cover this, it should help to land this. Also, this should probably be documented?

/CC @xzyfer

@niksy

niksy commented Oct 11, 2021

Copy link
Copy Markdown

@WraithKenny are you up for this?

@WraithKenny

Copy link
Copy Markdown
Contributor Author

Honestly, I've never quite figured out extending tests; I have no idea what I'm doing with regards to that. If anyone wants to adopt this issue/patch, you are more than welcome!

@XhmikosR

Copy link
Copy Markdown
Contributor

You'd need to rebase the branch first and then add 2 tests for the new property in https://github.com/dlmanning/gulp-sass/blob/master/test/main.js

@niksy

niksy commented Jan 25, 2022

Copy link
Copy Markdown

@XhmikosR @WraithKenny I’ve created new PR with tests

@XhmikosR

Copy link
Copy Markdown
Contributor

I don't have push rights, so @xzyfer will need to take care of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attach stats to data object

3 participants