Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable resolve for query and json parameters #2208

Merged
merged 16 commits into from
Jan 28, 2025
Merged

Enable resolve for query and json parameters #2208

merged 16 commits into from
Jan 28, 2025
+545 −89

Conversation

francescomucio
Copy link
Contributor

@francescomucio francescomucio commented Jan 13, 2025 •
edited
Loading

Description

Related Issues

Additional Context

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 4370a33
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6797e43911ef32000748201d

@francescomucio francescomucio mentioned this pull request Jan 13, 2025
Closed
@burnash burnash requested review from burnash and removed request for burnash January 13, 2025 12:41
@burnash burnash self-assigned this Jan 13, 2025
@francescomucio
Copy link
Contributor Author

@burnash feel free to review this

burnash
burnash requested changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please remove the commented code, and run make lint, the CI is failing with some mypy errors.

tests/sources/rest_api/conftest.py Outdated Show resolved Hide resolved
burnash
burnash approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @francescomucio

@burnash burnash merged commit aa5355d into dlt-hub:devel Jan 28, 2025
60 checks passed
@francescomucio francescomucio mentioned this pull request Jan 31, 2025
Open
rudolfix added a commit that referenced this pull request Feb 4, 2025
@rudolfix
Revert "Enable resolve for query and json parameters (#2208)"
7678ad9 
This reverts commit aa5355d.
@rudolfix rudolfix mentioned this pull request Feb 4, 2025
Merged
rudolfix added a commit that referenced this pull request Feb 4, 2025
@rudolfix
Revert "Enable resolve for query and json parameters" (#2265)
37f3d45 
* Revert "Enable resolve for query and json parameters (#2208)"

This reverts commit aa5355d.

* fixes poke tests, bumps version to 1.6.1
@burnash burnash mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnash burnash burnash approved these changes

Assignees

@burnash burnash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rest_api: Enable resolve in query parameters
2 participants
@francescomucio @burnash