Feat/514 rest_api: pluggable paginators #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willi-mueller
commented
Jul 7, 2024
willi-mueller
force-pushed
the
feat/514-pluggable-paginators
branch
from
30214a6 to
e30ce17
Compare
1 task
burnash
previously approved these changes
Jul 18, 2024
willi-mueller
force-pushed
the
feat/514-pluggable-paginators
branch
from
e4c7def to
c63149e
Compare
tests: - built-in paginator needs no registration - custom paginator can be registered - custom paginator is usable like built-in ones after registration - custom paginator cannot be created from config without registration tests that value passed in dict config is present in built object adds type check at runtime to prevent wrong usage and clarify intention.
willi-mueller
force-pushed
the
feat/514-pluggable-paginators
branch
from
c63149e to
39c3f31
Compare
burnash
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
Short description
Related Issues
TODO after merge