Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rest_api: Renames JSONResponsePaginator to JSONLinkPaginator. #523

Merged
merged 7 commits into from
Jul 24, 2024
Merged

rest_api: Renames JSONResponsePaginator to JSONLinkPaginator. #523

merged 7 commits into from
Jul 24, 2024

Conversation

willi-mueller
Copy link
Collaborator

@willi-mueller willi-mueller commented Jul 8, 2024 •
edited
Loading

Tell us what you do here

  • improving, documenting, or customizing an existing source: rest_api source

Short description

  • Renames the usages and documentation of JSONResponsePaginator to JSONLinkPaginator.
  • changes CI check for pinned dlt version to accept also branches or commits and tags and not only released version numbers.

A successful test suite depends on the PR dlt-hub/dlt#1558 to be merged and released.

Related Issues

TODO before merge

@willi-mueller willi-mueller marked this pull request as ready for review July 8, 2024 10:16
@willi-mueller willi-mueller mentioned this pull request Jul 8, 2024
Merged
@willi-mueller willi-mueller requested a review from burnash July 8, 2024 10:18
@willi-mueller willi-mueller force-pushed the feat/1495-rename-JSONResponsePaginator branch from 62b75a4 to 9af1836 Compare July 8, 2024 17:25
@willi-mueller willi-mueller force-pushed the feat/1495-rename-JSONResponsePaginator branch from c05185b to 55a098e Compare July 9, 2024 09:25
burnash
burnash previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @willi-mueller. Let's merge it together with dlt-hub/dlt#1558

@willi-mueller willi-mueller force-pushed the feat/1495-rename-JSONResponsePaginator branch from 5e8914f to 495e577 Compare July 19, 2024 07:19
@willi-mueller willi-mueller requested a review from burnash July 22, 2024 10:18
burnash
burnash requested changes Jul 22, 2024
View reviewed changes
sources/rest_api/requirements.txt Outdated Show resolved Hide resolved
@willi-mueller willi-mueller requested a review from burnash July 24, 2024 08:45
@willi-mueller willi-mueller self-assigned this Jul 24, 2024
burnash
burnash approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @willi-mueller

@willi-mueller willi-mueller merged commit 5486edd into master Jul 24, 2024
14 checks passed
burnash added a commit that referenced this pull request Jul 24, 2024
@burnash
Revert "rest_api: Renames JSONResponsePaginator to JSONLinkPaginator. (…
d9b2c2d 
…#523)"

This reverts commit 5486edd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnash burnash burnash approved these changes

Assignees

@willi-mueller willi-mueller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willi-mueller @burnash