Fix force-push guard comparing against HEAD instead of base branch#26
Merged
Conversation
The guard was comparing the push target against HEAD, but pushWithToken is called after checking out the version PR branch, so HEAD === branch always triggered the error. Use config.baseBranch instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
The changes in this PR will be included in the next version bump.
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Split the regex and add an inline disable comment for the intentional control character check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HEAD, butpushWithTokenis called after checking out the version PR branch — soHEAD === branchalways triggered the errorconfig.baseBranchinstead, which is the actual base branch (e.g.main)Test plan
bumpy ci releasecreates/updates the version PR without error🤖 Generated with Claude Code