Fix check to only count bump files from current branch#30
Merged
Conversation
The local `bumpy check` was counting all pending bump files in .bumpy/, so it would pass even if the current branch didn't add one. Now it filters to only bump files added/modified on the branch, matching the CI check behavior. Also extracts shared `filterBranchBumpFiles` helper and fixes empty bump file handling in both local and CI check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
The changes in this PR will be included in the next version bump.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
bumpy checkwas counting all pending bump files in.bumpy/, so it would pass even if the current branch didn't add one. Now it filters to only bump files added/modified on the branch, matchingbumpy ci checkbehavior.filterBranchBumpFileshelper inbump-file.tsused by bothcheckandci checkTest plan
bumpy checkshould failbumpy ci checkstill works correctly in CI🤖 Generated with Claude Code