Skip to content

Fix check to only count bump files from current branch#30

Merged
theoephraim merged 1 commit into
mainfrom
fix/check-branch-filter
Apr 21, 2026
Merged

Fix check to only count bump files from current branch#30
theoephraim merged 1 commit into
mainfrom
fix/check-branch-filter

Conversation

@theoephraim

Copy link
Copy Markdown
Member

Summary

  • bumpy check was counting all pending bump files in .bumpy/, so it would pass even if the current branch didn't add one. Now it filters to only bump files added/modified on the branch, matching bumpy ci check behavior.
  • Extracted shared filterBranchBumpFiles helper in bump-file.ts used by both check and ci check
  • Fixed empty bump file handling in both commands — empty bump files (no releases) are now properly detected and pass the check

Test plan

  • Push a branch with package changes but no bump file — bumpy check should fail
  • Push a branch with package changes and a bump file — should pass
  • Push a branch with an empty bump file — should pass with "no releases needed"
  • Verify bumpy ci check still works correctly in CI

🤖 Generated with Claude Code

The local `bumpy check` was counting all pending bump files in .bumpy/,
so it would pass even if the current branch didn't add one. Now it
filters to only bump files added/modified on the branch, matching the
CI check behavior. Also extracts shared `filterBranchBumpFiles` helper
and fixes empty bump file handling in both local and CI check.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bumpy-bot

Copy link
Copy Markdown
Collaborator

bumpy-frog

The changes in this PR will be included in the next version bump.

patch Patch releases

  • @varlock/bumpy 1.0.0 → 1.0.1

Bump files in this PR

Click here if you want to add another bump file to this PR


This comment is maintained by bumpy.

@theoephraim theoephraim merged commit 234e46a into main Apr 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants