fix(vscode-plugin): highlight URL fragments in @docs() decorator#742
Merged
theoephraim merged 6 commits intoJun 3, 2026
Merged
Conversation
Member
|
Thanks for this! Will take a look tomorrow. I just came across this too - https://github.com/johnsoncodehk/monogram |
added 2 commits
June 3, 2026 15:17
theoephraim
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When adding the item decorator @docs() with a URL that had a fragment, the fragment symbol itself

#fell out of the syntax scope:Fix
Removed
#from theunquoted-string-within-fn-call. Since this rule is bounded by parenthesis it should hold no special meaning, unless I've missed a special case 👀Added some tests to verify the behaviour, as well as multiline fn-calls.
Some examples containing the deprecated docsUrl decorator was changed to docs
After implementing the fix:

Let me know if I missed or need to change something!