Skip to content

fix(vscode-plugin): highlight URL fragments in @docs() decorator#742

Merged
theoephraim merged 6 commits into
dmno-dev:mainfrom
Shtian:fix/vscode-url-fragment-highlighting
Jun 3, 2026
Merged

fix(vscode-plugin): highlight URL fragments in @docs() decorator#742
theoephraim merged 6 commits into
dmno-dev:mainfrom
Shtian:fix/vscode-url-fragment-highlighting

Conversation

@Shtian
Copy link
Copy Markdown
Contributor

@Shtian Shtian commented Jun 3, 2026

Summary

When adding the item decorator @docs() with a URL that had a fragment, the fragment symbol itself # fell out of the syntax scope:
image

Fix

Removed # from the unquoted-string-within-fn-call. Since this rule is bounded by parenthesis it should hold no special meaning, unless I've missed a special case 👀

Added some tests to verify the behaviour, as well as multiline fn-calls.

Some examples containing the deprecated docsUrl decorator was changed to docs

After implementing the fix:
image

Let me know if I missed or need to change something!

@theoephraim
Copy link
Copy Markdown
Member

Thanks for this! Will take a look tomorrow.

I just came across this too - https://github.com/johnsoncodehk/monogram
which might help keep the grammar and highlighting all in sync with a bit less work 🤞

@theoephraim theoephraim merged commit 693e7de into dmno-dev:main Jun 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants