-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to QT6 version, add darwin support #226
Conversation
fd06754
to
a8285ed
Compare
a8285ed
to
46f9cb4
Compare
Thanks for the pull request. Would it be possible to split this one into two separate pull requests? Would make it a bit easier to test one thing at a time. |
It would, but the darwin part depends on qt6 first being merged, so i think it’s easier to develop both at the same time. |
Currently using this flake on nixos fails to run with the following error message: "[MainThread] ERROR: Qt: Cannot mix incompatible Qt library (6.8.2) with this library (6.8.1)". So I'm thinking it would likely be easier to get a linux build up and running first with qt6, then adding darwin support when that is working. |
I don’t think that is related to darwin, but i can try building on nixos and see if i get the same error |
No, that's not related to Darwin, it's just that I prefer pull requests solving one problem at a time. It might be either due to some impurity creeping in, causing plover to run using system libraries, or due to some kind of dependency conflict. |
It might be that the locked version of nixpkgs is causing something like that, where the system and plover qt versions are mismatched. If i get time later i can split into a qt6 pr and a darwin pr based on it. |
I don't get that error at all when i try running it. Is it just a warning, or does it just crash? And i also found that there are no icons, and the tray icon does not show up on darwin. |
Crashes (tested using latest nixos-unstable as the system distro) |
Closed in favor of #227 |
python311
to the standardpython3
, as the previous issues in nixpkgs have been fixed. This seems to also make the nixpkgs cache work properly.Should be ready when the pull request in upstream is merged