Skip to content

Add Concurrent Runners Resolution Logic #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

Add Concurrent Runners Resolution Logic #31

merged 3 commits into from
Jun 20, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 20, 2025

This PR implements logic to resolve the concurrentRunners configuration value from various input formats to a concrete integer for the core execution engine.

Changes Made

Core Implementation

  • Added resolveConcurrentRunners(config) function to src/config.js
  • Integrated the function call into the setConfig configuration processing pipeline
  • Function handles all specified resolution scenarios:
function resolveConcurrentRunners(config) {
  if (config.concurrentRunners === true) {
    // Cap at 4 only for the boolean convenience option
    return Math.min(os.cpus().length, 4);
  }
  // Respect explicit numeric values and default
  return config.concurrentRunners || 1;
}

Behavior Specifications

  • concurrentRunners: 11 (explicit values pass through unchanged)
  • concurrentRunners: trueMath.min(os.cpus().length, 4) (boolean convenience with cap)
  • concurrentRunners: 88 (no cap for explicit values, including > 4)
  • concurrentRunners: undefined1 (default value)

Testing

  • Added comprehensive unit tests covering all resolution scenarios
  • Tests include edge cases (null, false, 0 values)
  • Tests mock different CPU counts (1, 2, 8, 16 cores) to verify behavior
  • Integration test confirms resolved value is properly set in configuration
  • All existing tests continue to pass

Integration Points

  • Resolution happens during configuration processing in setConfig
  • Resolved value is available in the config object passed to core execution
  • Configuration flows through to resolved test contexts via resolveDetectedTests
  • No breaking changes to existing functionality

The implementation follows the project's patterns for configuration resolution and includes thorough test coverage for all specified behaviors.

Fixes #30.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Add Concurrent Runners Resolution Logic Add Concurrent Runners Resolution Logic Jun 20, 2025
@Copilot Copilot AI requested a review from hawkeyexl June 20, 2025 14:07
Copilot finished work on behalf of hawkeyexl June 20, 2025 14:07
@hawkeyexl hawkeyexl marked this pull request as ready for review June 20, 2025 14:28
Copy link
Contributor

coderabbitai bot commented Jun 20, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

promptless bot commented Jun 20, 2025

📝 Documentation updates detected!

New suggestion: Document concurrentRunners configuration option

@hawkeyexl hawkeyexl merged commit d4a33fd into main Jun 20, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Concurrent Runners Resolution Logic
2 participants