This repository was archived by the owner on May 4, 2021. It is now read-only.
Fix problem with bucket existence verification#32
Open
davidbnk wants to merge 1 commit intodocker-archive:masterfrom
Open
Fix problem with bucket existence verification#32davidbnk wants to merge 1 commit intodocker-archive:masterfrom
davidbnk wants to merge 1 commit intodocker-archive:masterfrom
Conversation
Right now the bash script is using grep to find the presence of the bucket name anywhere in the response of `aws s3 ls` The problem is that if you have something like this: ``` bash# aws s3 ls 2017-02-06 17:55:36 my-bucket-test ``` And now supose you want to run the script with a bucket named `my-bucket`, the `grep` will match the output and it will behave as if the bucket already exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the bash script is using grep to find the presence of the bucket name anywhere in the response of
aws s3 lsThe problem is that if you have something like this:
And now supose you want to run the script with a bucket named
my-bucket, thegrepwill match the output and it will behave as if the bucket already exists