Skip to content

opts: implement PlatformSlice option #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 8, 2025

I had these changes in a local branch, but it wasn't finished yet; TODO;

  • add tests
  • decide whether we want this in the opts package, or better to have it in a separate package (due to extra dependencies involved)
  • do we need a similar options for single platforms?
  • should this package include utilities for tab-completion?
  • should the String() format be symmetrical with the input value (no space between values?)

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 25.80645% with 23 lines in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (28f19a9) to head (7c8160f).
Report is 4 commits behind head on master.

❌ Your patch status has failed because the patch coverage (25.80%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6166      +/-   ##
==========================================
- Coverage   54.82%   54.79%   -0.04%     
==========================================
  Files         364      365       +1     
  Lines       30467    30483      +16     
==========================================
- Hits        16703    16702       -1     
- Misses      12789    12807      +18     
+ Partials      975      974       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants