-
Notifications
You must be signed in to change notification settings - Fork 2.1k
telemetry: lock the semconv version of the otel sdk #6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR locks the OpenTelemetry SDK semantic conventions version to prevent schema conflicts. The change updates OTel dependencies from v1.35.0 to v1.38.0 and implements a local telemetry SDK detector using a specific semconv version (v1.37.0) instead of relying on the SDK's default, which automatically updates with dependency changes.
Key Changes:
- Updated OTel core packages to v1.38.0 (otel, otel/metric, otel/trace)
- Replaced
resource.WithTelemetrySDK()with a customtelemetrySDKdetector - Pinned semantic conventions to v1.37.0
Reviewed Changes
Copilot reviewed 3 out of 71 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vendor.mod | Updates OTel dependencies from v1.35.0 to v1.38.0 and transitive dependencies |
| vendor.sum | Reflects checksums for updated dependency versions |
| cli/command/telemetry.go | Implements custom telemetry SDK detector with locked semconv v1.37.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vendor.mod
Outdated
| github.com/xeipuuv/gojsonschema v1.2.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.60.0 | ||
| go.opentelemetry.io/otel v1.35.0 | ||
| go.opentelemetry.io/otel v1.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious; was the OTEL version update needed for this to work, or would the previous version do as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous version would work.
This change prevents changes to the otel version from affecting the otel sdk version. This is done by copying the telemetry sdk implementation locally and using our own choice for semconv from within that. This prevents a schema conflict from happening since the otel version of the sdk gets implicitly updated whenever the semconv changes while we have to manually change ours. Now, we manually change both and they're locked to each other. Signed-off-by: Jonathan A. Sternberg <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
a80b440 to
153f7f1
Compare
|
Updated this to continue using the current semconv and OTEL version; I moved those updates to #6578 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI is happy; I'll move the other PR out of draft later, but wanted this path in without the Otel bump, to keep the option open to include this in a 28.x patch release.
This change prevents changes to the otel version from affecting the otel
sdk version. This is done by copying the telemetry sdk implementation
locally and using our own choice for semconv from within that.
This prevents a schema conflict from happening since the otel version of
the sdk gets implicitly updated whenever the semconv changes while we
have to manually change ours. Now, we manually change both and they're
locked to each other.