Write error to watcher error channel if Start() fails #13263
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up's loop will notice globalCtx is done, and invoke watcher.Stop(). Stop() reads from the watcher error channel. If Start() does not write an error, Stop() will never finish. Fixes docker#13262 Signed-off-by: Benedikt Radtke <[email protected]>
Trolldemorted
force-pushed
the
fixpermissionissuedeadlock
branch
from
0976251 to
3d1a3ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Current main fails to properly abort with
--watchon permission issues because:up.go:Up()noticesglobalCtxis done, callswatcher.Stop()watch.go:Stop()reads fromw.errChwatch.go:Stop()is deadlocked becausewatch.go:Starthas not and will not write tow.errChThe fix is simple: Ensure
watch.go:Start()writes the error fromwatchFnintow.errCh.Related issue
Fixes #13262