docs: record client lifetimes in AGENTS.md and point at the contributing guide - #4197
Draft
IsmaelMartinez wants to merge 1 commit into
Draft
IsmaelMartinez wants to merge 1 commit into
IsmaelMartinez wants to merge 1 commit into
Conversation
…ing guide Provider clients outlive a conversation in serve a2a and serve mcp, which is not visible from the provider code. The command table also duplicates the contributing guide, so name that page as canonical rather than copying it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qyjba1txhq3QsrpcGUt3FM
IsmaelMartinez
force-pushed
the
docs/agents-md-dedupe
branch
from
September 8, 2026 07:22
a963eee to
8d3631d
Compare
aheritier
approved these changes
Sep 14, 2026
aheritier
enabled auto-merge
September 14, 2026 16:26
Collaborator
|
please rebase to use our new workflows |
aheritier
marked this pull request as draft
September 15, 2026 08:06
auto-merge was automatically disabled
September 15, 2026 08:06
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things, both prompted by getting them wrong in #4190.
Client lifetimes. Provider clients are built when a team loads.
serve apiloads per session, butserve a2aandserve mcpload once at startup and reuse those clients for every conversation they serve. That is not visible from the provider code, and it is the difference between a per-conversation value and a per-deployment one. #4190 shipped the wrong version of exactly that until @yunus25jmi1 caught it. The note also points athttpclient.SessionIDFromContext, which already carries the session and is easy to miss.Duplication. The command table here repeats the contributing guide, and the two have already drifted: this file says to sign with
git commit -S, which a bot enforces, while that page says DCOgit commit -s, which nothing checks and one of the last thirty commits carries. Rather than copy more, this names that page as canonical. Reconciling the signing advice itself is left alone deliberately, since it is a maintainer call about which requirement is real.I have read access only, so treat this as a suggestion rather than a decision.
🤖 Generated with Claude Code