Skip to content

fix: recover delegated idle streams and preserve model override policy - #4247

Merged
aheritier merged 5 commits into
mainfrom
fix-delegation-stalls-model-overrides-v2
Sep 14, 2026
Merged

aheritier merged 5 commits into
mainfrom
fix-delegation-stalls-model-overrides-v2

Conversation

@aheritier

Copy link
Copy Markdown
Collaborator

Fixes #4232

Summary

  • Recover sentinel-only pre-response delegated idle streams with a one-time direct-transfer retry.
  • Make retry admission, cancellation, and budget propagation safe.
  • Preserve target-provider defaults when parallel_tool_calls is omitted.
  • Isolate per-agent CLI model override policy while preserving real model identity.
  • Add/update tests and documentation.

Validation

  • task build
  • task test
  • task lint
  • Scoped race/shuffle tests
  • Docs link check: only baseline-equivalent external 403/404 failures

The implementation is organized into these five logical commits:

  1. fix(runtime): classify idle streams before output
  2. fix(runtime): retry admitted delegated idle streams
  3. fix(runtime): recover direct task transfers
  4. fix(config): preserve omitted default model policies
  5. fix(config): isolate CLI model override policies

@aheritier
aheritier requested a review from a team as a code owner September 11, 2026 21:04
@aheritier aheritier added area/config For configuration parsing, YAML, environment variables area/docs Documentation changes area/runtime Runtime engine, agent loop execution, tool dispatch, loop detection area/sessions For features/issues/fixes related to session lifecycle (resume, persistence, export) area/skills Skills system and custom slash commands area/telemetry Telemetry, tracing, and metrics kind/fix PR fixes a bug (maps to fix:). Use on PRs only. labels Sep 11, 2026
@aheritier
aheritier enabled auto-merge September 11, 2026 21:40
@aheritier
aheritier force-pushed the fix-delegation-stalls-model-overrides-v2 branch from 715f865 to aaf83a7 Compare September 14, 2026 08:00
@aheritier
aheritier added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit 816e3b4 Sep 14, 2026
21 checks passed
@aheritier
aheritier deleted the fix-delegation-stalls-model-overrides-v2 branch September 14, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config For configuration parsing, YAML, environment variables area/docs Documentation changes area/runtime Runtime engine, agent loop execution, tool dispatch, loop detection area/sessions For features/issues/fixes related to session lifecycle (resume, persistence, export) area/skills Skills system and custom slash commands area/telemetry Telemetry, tracing, and metrics kind/fix PR fixes a bug (maps to fix:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transfer_task: retry once on "model stream stalled" errors; ApplyModelOverrides should inherit parallel_tool_calls

2 participants