fix(record): require Docker auth only for HTTPS docker.com gateways - #4252
Open
aheritier wants to merge 1 commit into
Open
fix(record): require Docker auth only for HTTPS docker.com gateways#4252aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
aheritier
marked this pull request as ready for review
September 12, 2026 11:17
aheritier
marked this pull request as draft
September 12, 2026 18:45
Require Docker Desktop authentication only for HTTPS docker.com gateways while retaining loopback trust for forwarded encrypted configuration. Scrub encrypted config and its digest independently from recording captures, and remove both before forwarding to untrusted or direct upstreams. Fixes #4250
aheritier
force-pushed
the
fix/record-gateway-docker-auth-4250
branch
from
September 13, 2026 07:33
be4637f to
bb6c474
Compare
aheritier
marked this pull request as ready for review
September 13, 2026 09:51
aheritier
enabled auto-merge
September 13, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4250.
--recordand--fakeroute provider traffic through a local capture proxy so requests can be recorded or replayed. The proxy’s loopback address remains trusted for local routing, but loopback and third-party gateways no longer trigger a Docker Desktop authentication requirement.What changed
docker.comand its subdomains.docker.comdomain.encrypted_agent_configand its digest:Security behavior
Encrypted agent configuration and its digest are never persisted in recording cassettes. They are also scrubbed before requests are sent directly to untrusted providers or when no upstream gateway is configured. Trusted loopback and Docker gateways retain the configuration needed for their routing behavior.
Regression context
This fixes a recent interaction regression rather than a long-standing
--recordissue:--recordwas introduced in December 2025.The issue was reported in v1.138.1. Releases containing the July 2026 routing change are potentially affected; the precise first released version has not been pinned.
References: #3428; commits b996731, b5a9b8b, and 9e67ddd.
Tests
Added and updated coverage for:
docker.comdomain matching;Validated with:
task buildtask testtask lint