feat: Add CodeItem as pydantic type, update export methods and APIs #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2025 15:15
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
cau-git
changed the title
added 5 commits
January 15, 2025 12:14
Signed-off-by: Matteo-Omenetti <[email protected]>
Signed-off-by: Matteo-Omenetti <[email protected]>
Signed-off-by: Matteo-Omenetti <[email protected]>
Signed-off-by: Matteo-Omenetti <[email protected]>
Signed-off-by: Matteo-Omenetti <[email protected]>
Matteo-Omenetti
force-pushed
the
code_item
branch
from
91a6650 to
378209e
Compare
cau-git
previously approved these changes
Jan 15, 2025
Signed-off-by: Michele Dolfi <[email protected]>
|
I think we should anyway consider having a stable enum for the programming languages. From the test about I see upcoming problems with Python vs python vs py, CSharp vs C# vs c#, etc |
vagenas
reviewed
Jan 17, 2025
Signed-off-by: Christoph Auer <[email protected]>
vagenas
reviewed
Jan 17, 2025
docling_core/types/doc/labels.py
Outdated
Comment on lines
146
to
202
| ADA = "Ada" | ||
| AWK = "Awk" | ||
| BASH = "Bash" | ||
| C = "C" | ||
| C_SHARP = "C#" | ||
| C_PLUS_PLUS = "C++" | ||
| CMAKE = "CMake" | ||
| COBOL = "COBOL" | ||
| CSS = "CSS" | ||
| CEYLON = "Ceylon" | ||
| CLOJURE = "Clojure" | ||
| CRYSTAL = "Crystal" | ||
| CUDA = "Cuda" | ||
| CYTHON = "Cython" | ||
| D = "D" | ||
| DART = "Dart" | ||
| DOCKERFILE = "Dockerfile" | ||
| ELIXIR = "Elixir" | ||
| ERLANG = "Erlang" | ||
| FORTRAN = "FORTRAN" | ||
| FORTH = "Forth" | ||
| GO = "Go" | ||
| HTML = "HTML" | ||
| HASKELL = "Haskell" | ||
| HAXE = "Haxe" | ||
| JAVA = "Java" | ||
| JAVASCRIPT = "JavaScript" | ||
| JULIA = "Julia" | ||
| KOTLIN = "Kotlin" | ||
| LISP = "Lisp" | ||
| LUA = "Lua" | ||
| MATLAB = "Matlab" | ||
| MOONSCRIPT = "MoonScript" | ||
| NIM = "Nim" | ||
| OCAML = "OCaml" | ||
| OBJECTIVEC = "ObjectiveC" | ||
| OCTAVE = "Octave" | ||
| PHP = "PHP" | ||
| PASCAL = "Pascal" | ||
| PERL = "Perl" | ||
| PROLOG = "Prolog" | ||
| PYTHON = "Python" | ||
| RACKET = "Racket" | ||
| RUBY = "Ruby" | ||
| RUST = "Rust" | ||
| SML = "SML" | ||
| SQL = "SQL" | ||
| SCALA = "Scala" | ||
| SCHEME = "Scheme" | ||
| SWIFT = "Swift" | ||
| TYPESCRIPT = "TypeScript" | ||
| VISUALBASIC = "VisualBasic" | ||
| XML = "XML" | ||
| YAML = "YAML" | ||
| BC = "bc" | ||
| DC = "dc" | ||
| UNKNOWN = "unknown" |
There was a problem hiding this comment.
These are partially sorted alphabetically, but not completely — I would best make the sorting consistent.
…f string but variable name
Matteo-Omenetti
force-pushed
the
code_item
branch
2 times, most recently
from
fa63048 to
86cbef2
Compare
cau-git
approved these changes
Jan 17, 2025
dolfim-ibm
approved these changes
Jan 17, 2025
muhark
added a commit
to muhark/docling-core
that referenced
this pull request
Mar 19, 2025
…ocling-project#129) * added code item * added code item * added code item Signed-off-by: Matteo-Omenetti <[email protected]> * added code item Signed-off-by: Matteo-Omenetti <[email protected]> * added code item Signed-off-by: Matteo-Omenetti <[email protected]> * added code item Signed-off-by: Matteo-Omenetti <[email protected]> * added code item Signed-off-by: Matteo-Omenetti <[email protected]> * add constraints to allow numpy > 2.1.0 on python3.13 and others Signed-off-by: Michele Dolfi <[email protected]> * Add CodeItem to ContentItem Signed-off-by: Christoph Auer <[email protected]> * added CodeItem in ContentItem tagged union. * added enum for programming languages * removed double CodeItem in ContentItem Union * fixed type of code_language in CodeItem class * fixed sorting of programming languages, not sorted anymore by value of string but variable name --------- Signed-off-by: Matteo-Omenetti <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Signed-off-by: Christoph Auer <[email protected]> Co-authored-by: Matteo-Omenetti <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> Co-authored-by: Christoph Auer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.