Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add data model types from docling-parse #186

Merged
merged 10 commits into from
Mar 13, 2025
Merged

feat: Add data model types from docling-parse #186

merged 10 commits into from
Mar 13, 2025

Conversation

cau-git
Copy link
Contributor

@cau-git cau-git commented Mar 11, 2025 •
edited
Loading

Transfers all the data models from docling-parse to a new unit in docling-core.

@mergify Mergify
Copy link

mergify bot commented Mar 11, 2025 •
edited by cau-git
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@cau-git
Copy link
Contributor Author

cau-git commented Mar 12, 2025 •
edited
Loading

TODO

  • PdfTextcell.widget should be an enum.

cau-git added 3 commits March 12, 2025 13:49
@cau-git
update comments
ddb2dec 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git
Rewrite BoundingRectangle.to_bounding_box()
7cb8088 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git
Add PdfCellRenderingMode
8e474a9 
Signed-off-by: Christoph Auer <[email protected]>
This was referenced Mar 12, 2025
Merged
Open
@cau-git
Update model_validator
dd33c36 
Signed-off-by: Christoph Auer <[email protected]>
PeterStaar-IBM
PeterStaar-IBM requested changes Mar 13, 2025
View reviewed changes
@cau-git
Copy link
Contributor Author

cau-git commented Mar 13, 2025

@PeterStaar-IBM Requested changes are addressed.

@cau-git cau-git requested a review from PeterStaar-IBM March 13, 2025 15:05
@PeterStaar-IBM PeterStaar-IBM merged commit a86a4a3 into main Mar 13, 2025
8 checks passed
@PeterStaar-IBM PeterStaar-IBM deleted the cau/docling-parse-types branch March 13, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterStaar-IBM PeterStaar-IBM PeterStaar-IBM approved these changes

@vagenas vagenas Awaiting requested review from vagenas

@dolfim-ibm dolfim-ibm Awaiting requested review from dolfim-ibm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cau-git @PeterStaar-IBM