Skip to content

Conversation

@vagenas
Copy link
Collaborator

@vagenas vagenas commented Oct 21, 2025

Main goal has been to establish metadata model that:

  • allows both prescribed and custom fields, with a way to distinguish the two
  • allows both common and type-specific fields, so that we can further specify the metadata reqs e.g. for PictureItem
  • accounts for serialization and deserialization, e.g. ideally avoiding serializing additional data if no meta info available

@mergify
Copy link

mergify bot commented Oct 21, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 93.97590% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/types/doc/document.py 92.24% 9 Missing ⚠️
docling_core/transforms/serializer/markdown.py 96.29% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

DCO Check Passed

Thanks @vagenas, all your commits are properly signed off. 🎉

Signed-off-by: Panos Vagenas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant