-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(msexcel): ignore invisible sheet #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(msexcel): ignore invisible sheet #1876
Conversation
I, Qiefan Jiang <[email protected]>, hereby add my Signed-off-by to this commit: ca391f4 Signed-off-by: Qiefan Jiang <[email protected]>
✅ DCO Check Passed Thanks @ealyn, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
@ealyn I would be more in favor to not skip the invisible_sheet, but rather updeate the ContentLayer (eg set it to background instead of the default body). see: |
@PeterStaar-IBM The meaning is slightly different between |
I agree, just added extra content-layers to address this: docling-project/docling-core#345 |
@ealyn We just merged another content-layer "INVISIBLE". If you add this and do the code reformatting, we would be happy to merge! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
@ealyn do you have any update on this PR? |
@ceberam Just because I'm busy in july, I'll refactor this feature in august. |
As WYSIWYG, filter invisible sheets.
Checklist: