fix: unwrap <p> tags around <a> in top-level sidebar items #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Koooooo-7
reviewed
Jul 25, 2025
There was a problem hiding this comment.
I think the root cause may be the styling since the display:none apply to all the non a elements.
As a single line in _sidebar.md , which does't as a group but a link, we need reconsider how to structure the sidebar and refine the css selector.
docsify/src/themes/shared/_sidebar.css
Line 91 in be21637
&.collapse {
> :not(a) {
display: none;
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are some issues with clicking on awesome and changelog. https://preview.docsifyjs.org/#/awesome
The solution is to remove the p tag from the top level
<li><p><a></a></p></li>.Related issue, if any:
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change?
Yes
Tested in the following browsers: