-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Tree][NestedSet] Fix inserting multiple roots in one flush #2932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Tree][NestedSet] Fix inserting multiple roots in one flush #2932
Conversation
The change in When debugging the failing test case I noticed that the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 78.53% 78.44% -0.09%
==========================================
Files 168 168
Lines 8790 8809 +19
==========================================
+ Hits 6903 6910 +7
- Misses 1887 1899 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@phansys Is there anything I need to do to get this one merged? Thanks a lot for your help. |
Signed-off-by: Stefan Gehrig <[email protected]>
Signed-off-by: Stefan Gehrig <[email protected]>
Signed-off-by: Stefan Gehrig <[email protected]>
Signed-off-by: Stefan Gehrig <[email protected]>
2156abe
to
cf528c8
Compare
This PR tries to solve the issue described in #2582. Currently it only provides a test case that reproduces the issue and the observations made in #2582 (comment) (persisting roots first) and in #2582 (comment) (doing two flushes).
\Gedmo\Tests\Tree\Issue\Issue2582Test::testInsertTwoRootsInOneFlush
fails as expected right now because it is a direct replication of the issue.\Gedmo\Tests\Tree\Issue\Issue2582Test::testInsertTwoRootsInOneFlushRootsFirst
and\Gedmo\Tests\Tree\Issue\Issue2582Test::testInsertTwoRootsInTwoFlushes
both succeed.