Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - nested dto's doesn't have arguments in good order and Dto with only objects bug #11825

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

eltharin
Copy link
Contributor

@eltharin eltharin commented Feb 5, 2025

for resolve #11824

add arguments sort for nested dto's contructors

Working on another PR, I figure that when a Dto have only objects as arguments newObjectMappings was not filled so I move parent declaration in newObject (keeping BC)

@eltharin eltharin changed the title add order for args for nested dtos [BUG] - nested dto's doesn't have arguments in good order Feb 5, 2025
@eltharin eltharin marked this pull request as draft February 14, 2025 09:09
@eltharin eltharin marked this pull request as ready for review February 14, 2025 11:11
@eltharin eltharin force-pushed the bug_arg_order branch 4 times, most recently from b009897 to f4c5705 Compare February 15, 2025 09:40
@eltharin eltharin changed the title [BUG] - nested dto's doesn't have arguments in good order FIX - nested dto's doesn't have arguments in good order and Dto with only objects bug Feb 15, 2025
@eltharin eltharin force-pushed the bug_arg_order branch 5 times, most recently from 9fe2c71 to fb84619 Compare February 18, 2025 14:21
@eltharin eltharin force-pushed the bug_arg_order branch 2 times, most recently from 7934f1a to 3fd6a3f Compare February 20, 2025 08:24
nested dto are not in good argument order
dto with only dto does'nt work
@greg0ire greg0ire merged commit bd0509a into doctrine:3.3.x Mar 5, 2025
84 checks passed
@greg0ire
Copy link
Member

greg0ire commented Mar 5, 2025

Thanks @eltharin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - nested object argument are not in asked order
3 participants