Fix JoinedSubclassPersister when multiple entities are inserted #11934
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greg0ire can this PR be merged please? Test for this cannot be easily added (it will be very long), I hope the description is enough. If you require better commit description please let me know and what exactly should I mention there. Thank you. |
|
Please include a description of the problem and a description of the fix in the commit message |
Fix JoinedSubclassPersister as BasicEntityPersister was already fixed in doctrineGH-10735. I have extracted this from reworked doctrineGH-8260 which will target v3.x. The fix can be verified by modifying UnitOfWork to execute `BasicEntityPersister::executeInserts()` for multiple entities at once for the same entity class/persister instance - https://github.com/doctrine/orm/blob/2.20.3/src/UnitOfWork.php#L1186 - then reproducible on `Doctrine\Tests\ORM\Functional\Ticket\GH10531Test::testInserts` test. As extending/modifying UnitOfWork in tests in not easily possible, I submit this fix for v2.x without a test.
mvorisek
force-pushed
the
fix_joined_subclass_persister_insert_of_multiple_entities
branch
from
06e6d19 to
c32852b
Compare
|
I have adjusted the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as in base/BasicEntityPersister class - https://github.com/doctrine/orm/blob/2.20.3/src/Persisters/Entity/BasicEntityPersister.php#L310. Missed in #10735.
I have extracted this from reworked #8260 which will target v3.x.
The fix can be verified by modifying UnitOfWork to execute
BasicEntityPersister::executeInserts()for multiple entities at once for the same entity class/persister instance - https://github.com/doctrine/orm/blob/2.20.3/src/UnitOfWork.php#L1186 - then reproducible onDoctrine\Tests\ORM\Functional\Ticket\GH10531Test::testInsertstest.As extending/modifying UnitOfWork in tests in not easily possible, I submit this fix for v2.x without a test.