Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout for PDF extraction from OpenOffice supported document format. #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Timeout for PDF extraction from OpenOffice supported document format. #34

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f76cae3
Timeout for PDF extraction from OpenOffice supported document format
vrybas Jan 13, 2012
51b6f7d
Command line parameter and documentation update for timeout option
vrybas Jan 13, 2012
e52a17d
Fixed help message for `--timeout` option
vrybas Jun 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ <h2 id="usage">Usage</h2>
<b>xls</b> and so on, as well as <b>html</b>, <b>odf</b>, <b>rtf</b>, <b>swf</b>, <b>svg</b>, and <b>wpd</b>.
The first time that you convert a new file type, OpenOffice will lazy-load
the code that processes it &mdash; subsequent conversions will be much faster.
</p>
<br/>You can use the <tt>--timeout</tt> flag to increase or decrease time before 'error on timeout' exception.
Useful when you convert huge documents. Default timeout is 1 hour (more than enough to convert 1000-paged document).
</p>
<pre>
docsplit pdf documentation/*.html</pre>
<pre>
Expand Down
3 changes: 2 additions & 1 deletion lib/docsplit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def self.extract_images(pdfs, opts={})
# If the document is in an image format, use GraphicsMagick to extract the PDF.
def self.extract_pdf(docs, opts={})
out = opts[:output] || '.'
timeout = opts[:timeout] || 3600
FileUtils.mkdir_p out unless File.exists?(out)
[docs].flatten.each do |doc|
ext = File.extname(doc)
Expand All @@ -71,7 +72,7 @@ def self.extract_pdf(docs, opts={})
if GM_FORMATS.include?(`file -b --mime #{ESCAPE[doc]}`.strip.split(/[:;]\s+/)[0])
`gm convert #{escaped_doc} #{escaped_out}/#{escaped_basename}.pdf`
else
options = "-jar #{ROOT}/vendor/jodconverter/jodconverter-core-3.0-beta-4.jar -r #{ROOT}/vendor/conf/document-formats.js"
options = "-jar #{ROOT}/vendor/jodconverter/jodconverter-core-3.0-beta-4.jar -t #{timeout} -r #{ROOT}/vendor/conf/document-formats.js"
run "#{options} #{escaped_doc} #{escaped_out}/#{escaped_basename}.pdf", [], {}
end
end
Expand Down
3 changes: 3 additions & 0 deletions lib/docsplit/command_line.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ def parse_options
opts.on('--no-clean', 'disable cleaning of OCR\'d text') do |c|
@options[:clean] = false
end
opts.on('-t', '--timeout [SEC]', 'Timeout for PDF extraction from OpenOffice document format (default is 1 hour)') do |t|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change this message to "Timeout for PDF extraction from OpenOffice supported document format" so as not to lead people into thinking the flag will only apply to OpenOffice files and not .doc, .xlsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alxndrmlr, will do thanks

@options[:timeout] = t
end
opts.on('-r', '--rolling', 'generate images from each previous image') do |r|
@options[:rolling] = true
end
Expand Down