Phase 1: macOS notifications, dock badge, and in-app banner controls#36
Open
cicav wants to merge 1 commit into
Open
Phase 1: macOS notifications, dock badge, and in-app banner controls#36cicav wants to merge 1 commit into
cicav wants to merge 1 commit into
Conversation
New: - NotificationService: UNUserNotificationCenter wrapper with dock badge, sound, and in-app banner delegate support Preferences (persisted in preferences.json): - Notify on New Messages - Notify on Approval Requests - Show In-App Banners (foreground notifications) - Notification Sound Triggers: - sendMessageToSelectedSession / startNewSession success → message notification - Approval errors caught in sendMessage → approval notification - NSApplication.didBecomeActive → clear badge + delivered notifications Settings UI: - 4 toggles in Hermes menu, after the auto-update section Localization: en / zh-Hans / ru
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds macOS system notifications, dock badge, and notification sound for Hermes Desktop chat.
What
New
NotificationServicewrapsUNUserNotificationCenterto deliver local notifications when:Settings (Hermes menu → Notification section)
Architecture
NotificationService—@MainActorsingleton managed byAppState, configured via@Publishedpreferences inConnectionStorepreferences.jsonalongside existing settingswillPresentdelegate respectsshowInAppBanners+soundEnabledflagsNSApplication.didBecomeActiveNotificationFiles Changed
Services/Notifications/NotificationService.swiftServices/Storage/ConnectionStore.swiftApp/AppState.swiftApp/HermesDesktopCommands.swiftResources/*.lproj/Localizable.strings.github/workflows/macos-ci.ymlKnown limitations (noted for future iteration)
Testing
Tested manually with all toggle combinations: foreground banners, background banners, badge count, badge clear, sound on/off, approval notifications. CI verified on macos-15 runner (build + package).