Fix empty host selection state#47
Open
kopertop wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an empty-state bug where saving a host persists it locally but leaves Hermes Desktop without an active host selection.
Root Cause
AppState.saveConnection(_:)saved the profile but did not promote it toactiveConnectionIDor persist it aslastConnectionIDwhen the app had no active host.On launch,
AppStatealso trustedlastConnectionIDdirectly, so a missing or stale preference could strand valid saved hosts inconnections.json.Changes
lastConnectionIDby selecting the most recently connected/updated saved host.Validation
./scripts/run-tests.shpassed with 116 tests.Co-authored by Codex