Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable pagination for clusters #1660

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Re-enable pagination for clusters #1660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7260443
Uncomment pagination for clusters
mikaelGusse Mar 3, 2025
8c7cc0b
Set pagination=true by default in clusters table
rien Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/components/clustering/ClustersTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</span>
</template>

<!-- Temporary hack to hide pagination when disabled -->
<!-- Hide the pagination buttons if pagination is disabled -->
<template v-if="!pagination" #bottom>
<div />
</template>
Expand All @@ -53,7 +53,7 @@ interface Props {
pagination?: boolean;
}

const props = withDefaults(defineProps<Props>(), {});
const props = withDefaults(defineProps<Props>(), { pagination: true });
const router = useRouter();
const pairStore = usePairStore();

Expand Down
1 change: 1 addition & 0 deletions web/src/views/analysis/overview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
<clusters-table
:clusters="clustersOverview"
:limit="10"
:pagination="false"
concise
disable-sorting
/>
Expand Down Expand Up @@ -322,7 +323,7 @@
return x1 <= apiStore.cutoff ? "rgba(25, 118, 210, 0.25)" : "#1976D2";
};

const gotoSurvey = () => {

Check warning on line 326 in web/src/views/analysis/overview.vue

View workflow job for this annotation

GitHub Actions / Web 🌐 - lint 📏 (22) 

'gotoSurvey' is assigned a value but never used
router.push("https://ugent.qualtrics.com/jfe/form/SV_6QpMmrEuuoGSMWW");
}
</script>
Expand Down