fix(ingest): accept --flag=value equals form in the CLI parser#37
Merged
Conversation
The ingest CLI parsed only the space form (`--provenance value`). But dogfood-swarm's commands/persist.js invokes it via execSync as `node run.js --provenance=stub --file=...` (equals form), which fell through to positionalArgs — `provenanceMode` stayed null and the CLI died with "--provenance flag is required", silently breaking `swarm persist --ingest` on every platform. Parse `--flag=value` alongside `--flag value` for --provenance / --file / --payload. Surfaced by the persist exit-code test in dogfood-swarm/meta-amendB-operator-output.test.js during the self-audit; that test stayed green (the malformed run still exits non-zero), but the ingest never actually ran. New equals-form-args.test.js pins both forms + a control that proves the missing-flag error still fires when omitted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-audit follow-up. The ingest CLI parsed only
--flag value; dogfood-swarm'scommands/persist.jsinvokes it as--provenance=stub --file=...(equals form), so--provenanceread as missing → "flag is required" →swarm persist --ingestsilently failed on every platform.Fix: parse
--flag=valuealongside--flag valuefor--provenance/--file/--payload. Newequals-form-args.test.jspins both forms + a control. Ingest suite 120 → 123,npm run verifygreen.🤖 Generated with Claude Code