Merge pull request #5 from doggydoggy0101/feature/adjust-code-structure

🎨 adjust code structure
doggydoggy0101 · Feb 3, 2025 · 3f01d67 · 3f01d67
2 parents 4a50d4d + f2e9bee
commit 3f01d67
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.11)
-project(QGM VERSION 1.0.0)
+project(registration VERSION 1.0.0)
 set(CMAKE_CXX_STANDARD 17)
 
 option(BUILD_PYTHON "Build python wrappers" OFF)
@@ -21,6 +21,10 @@ message(STATUS "Building source done")
 
 
 if (BUILD_PYTHON)
+    set(Python3_FIND_STRATEGY LOCATION)  # find active Python for venv
+    find_package(Python3 REQUIRED COMPONENTS Interpreter)
+    message(STATUS "Using Python executable: ${PYTHON_EXECUTABLE}")
+
     add_subdirectory(third-party/pybind11)
     add_subdirectory(python)
     message(STATUS "Building python wrapper done")

diff --git a/README.md b/README.md
@@ -15,7 +15,7 @@ Official implementation of my master thesis "Algorithms for Geman-McClure Robust
     - [Prerequisites](#prerequisites)
     - [Build](#build)
     - [(optional) Build with Python binding](#optional-build-with-python-binding)
-  - [:books: Example Usages](#books-example-usages)
+  - [:books: Example usages](#books-example-usages)
   - [:card\_file\_box: Related works](#card_file_box-related-works)
 
 ## :gear: Setup
@@ -57,13 +57,13 @@ python3 -m pip install numpy
 
 mkdir build
 cd build
-cmake .. -DBUILD_PYTHON=ON -DPYTHON_EXECUTABLE=$(which python3)
+cmake .. -DBUILD_PYTHON=ON
 make
 
 cd python && pip install .
 ```
 
-## :books: Example Usages
+## :books: Example usages
 
 We provide the following robust point cloud registration solvers:
 

diff --git a/registration/include/registration/gnc.h b/registration/include/registration/gnc.h
@@ -55,7 +55,7 @@ double compute_initial_mu(double& res_sq, std::string& robust, double& c);
 void update_mu(double& mu, std::string& robust, double& gnc_factor);
 
 /**
- * @brief Weight update in the QGM algorithm.
+ * @brief Weight update in the GNC algorithm.
  *
  * @param terms A vector of the quadratic terms of square of residuals.
  * @param x The variable.