Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p12tool #999

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add p12tool #999

merged 1 commit into from
Mar 20, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Mar 18, 2024

The p12tool command has been moved from pki-tools to jss-tools.

https://github.com/edewata/jss/blob/tools/docs/changes/v5.6.0/Packaging-Changes.adoc

Note: Some tests are failing due to conflicts. They need to be rerun after merging PKI PR #4699.

The p12tool command has been moved from pki-tools to jss-tools.
@edewata
Copy link
Contributor Author

edewata commented Mar 19, 2024

@fmarco76 This is ready for review now. I've fixed some build issues. There's still a problem with the postgresql test but it seems to be an existing/unrelated issue.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Mar 20, 2024

@fmarco76 Thanks!

@edewata edewata merged commit dfd7066 into dogtagpki:master Mar 20, 2024
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants