-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for subsystem logging.properties #4962
base: master
Are you sure you want to change the base?
Conversation
The CMSEngine, ACMEEngine, and ESTEngine have been modified to support subsystem logging.properties. If the file exists, it can be used to configure the logging level in various libraries (e.g. RESTEasy) to help troubleshooting. The CA, ACME, and EST tests have been modified to create the subsystem logging.properties then check the debug log. https://github.com/dogtagpki/pki/wiki/Configuring-Subsystem-Debug-Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing purpose I think it is as quicker as modify the logging.properties
in the webapp.
If this is a was to allow different customisation in case of multiple instances running in the same server then we should provide a full customisation of the logger.
String value = properties.getProperty(key); | ||
|
||
logger.info("- " + key + ": " + value); | ||
if (!key.endsWith(".level")) continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we call the file logging.properties
I am expecting that the provided values should overwrite the existing to modify the logs. So I would try to update the full configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I can try that. I wasn't sure whether the LogManager
will override just the params specified in the custom logging.properties
or replace the entire logging config with the custom logging.properties
(meaning the handlers need to be redefined in the custom logging.properties
).
|
||
logger.info("- " + key + ": " + value); | ||
if (!key.endsWith(".level")) continue; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
|
||
logger.info("CMSEngine: - " + key + ": " + value); | ||
if (!key.endsWith(".level")) continue; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
Yes, for testing we can just modify the default
Even with a single instance, the custom |
The
CMSEngine
,ACMEEngine
, andESTEngine
have been modified to support subsystemlogging.properties
. If the file exists, it can be used to configure the logging level in various libraries (e.g. RESTEasy) to help troubleshooting.The CA, ACME, and EST tests have been modified to create the subsystem
logging.properties
then check the debug log.https://github.com/dogtagpki/pki/wiki/Configuring-Subsystem-Debug-Log
If RESTEasy logging is enabled, it will show something like this: