Skip to content

Prepend main css file to the main bundle's css file #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Prepend main css file to the main bundle's css file #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81089a7
If main.css exists, pass path down to bootstrap plugin
KaneFreeman May 14, 2021
ce777f8
Ignore .vscode path
KaneFreeman May 14, 2021
347f0b5
Remove main.css from bootstrap module
KaneFreeman May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ npm-debug.log
yarn.lock
/test-app/package-lock.json
/test-app/.dojorc
.vscode/
3 changes: 2 additions & 1 deletion src/base.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ export default function webpackConfigFactory(args: any): webpack.Configuration {
staticOnly.push('build-elide');
entry = {
[bootstrapEntry]: removeEmpty([
existsSync(mainCssPath) ? mainCssPath : null,
'@dojo/framework/shim/Promise',
'@dojo/webpack-contrib/bootstrap-plugin/async'
])
Expand Down Expand Up @@ -498,6 +497,7 @@ export default function webpackConfigFactory(args: any): webpack.Configuration {
args.locale && new CldrPlugin(),
new webpack.DefinePlugin({
__MAIN_ENTRY: JSON.stringify(mainEntryPath),
__MAIN_CSS_PATH: JSON.stringify(existsSync(mainCssPath) ? mainCssPath : null),
__DOJO_SCOPE: `'${libraryName}'`
}),
!isExperimentalSpeed &&
Expand All @@ -515,6 +515,7 @@ export default function webpackConfigFactory(args: any): webpack.Configuration {
!singleBundle &&
new BootstrapPlugin({
entryPath: mainEntryPath,
cssPath: existsSync(mainCssPath) ? mainCssPath : null,
shimModules: [
{
module: '@dojo/framework/shim/IntersectionObserver',
Expand Down