Skip to content

Use IndexMap to preserve insertion ordering #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: kariy/public-path
Choose a base branch
from
Open

Use IndexMap to preserve insertion ordering #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2741d4
use `IndexMap` for multiproof
kariy Dec 19, 2024
8b509fd
Bump `starknet-types-core` to `0.1.8`
kariy Apr 16, 2025
c59f52e
Bump `starknet-types-core` to `0.2.0`
kariy Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ serde = { version = "1.0.195", default-features = false, features = [
"derive",
"alloc",
] }
starknet-types-core = { version = "0.1.7", default-features = false, features = [
starknet-types-core = { version = "0.2", default-features = false, features = [
"hash",
"parity-scale-codec",
"alloc",
Expand All @@ -46,6 +46,7 @@ starknet-types-core = { version = "0.1.7", default-features = false, features =
rocksdb = { optional = true, version = "0.22", features = [
"multi-threaded-cf",
] }
indexmap = "2.2.6"

[dev-dependencies]
env_logger = "0.11.3"
Expand Down
5 changes: 3 additions & 2 deletions src/trie/proof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ use crate::{
merkle_node::{Node, NodeHandle},
tree::NodeKey,
},
BitSlice, BitVec, BonsaiDatabase, BonsaiStorageError, HashMap, HashSet,
BitSlice, BitVec, BonsaiDatabase, BonsaiStorageError, HashSet,
};
use core::{marker::PhantomData, mem};
use hashbrown::hash_set;
use indexmap::IndexMap;
use starknet_types_core::{felt::Felt, hash::StarkHash};

#[derive(Debug, thiserror::Error)]
Expand Down Expand Up @@ -58,7 +59,7 @@ impl ProofNode {
}

#[derive(Debug, Clone)]
pub struct MultiProof(pub HashMap<Felt, ProofNode>);
pub struct MultiProof(pub IndexMap<Felt, ProofNode>);
impl MultiProof {
/// If the proof proves more than just the provided `key_values`, this function will not fail.
/// Not the most optimized way of doing it, but we don't actually need to verify proofs in madara.
Expand Down
Loading