Skip to content

feat: added warning messages for when sierra file is too big or too many felts #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: added warning messages for when sierra file is too big or too many felts #3183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 36 additions & 13 deletions bin/sozo/src/commands/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,21 +155,44 @@ impl BuildArgs {
// directly during the compilation to get the data we need from it.
config.tokio_handle().block_on(bindgen.generate(None)).expect("Error generating bindings");

if self.stats != StatOptions::default() {
let world = WorldLocal::from_directory(
ws.target_dir_profile().to_string(),
ws.load_profile_config().unwrap(),
)?;

let world_stat = world.to_stat_item();
let mut stats = vec![world_stat];

for r in world.resources.values() {
if r.resource_type() != ResourceType::Namespace {
stats.push(r.to_stat_item());
}
let world = WorldLocal::from_directory(
ws.target_dir_profile().to_string(),
ws.load_profile_config().unwrap(),
)?;
let world_stat = world.to_stat_item();
let mut stats = vec![world_stat];
for r in world.resources.values() {
if r.resource_type() != ResourceType::Namespace {
stats.push(r.to_stat_item());
}
}

// Check limits and emit warnings for EVERY compilation
for stat in &stats {
// Sierra file size check (4,089,446 bytes)
if stat.sierra_file_size > 4_089_446 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move those magic values to constants? They are used below in the code, they may be extracted from the from implementation and put at the top of this module (with a link to the sn doc that mentioned those limits).

eprintln!(
"{}: Sierra file size ({:.2}MB, {} bytes) exceeds network limit of 4,089,446 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rework a bit the text to make it more readable:

  1. We can remove warning word, and print in yellow is ok to note a warning.
  2. Wdyt about something like
    Resource <TAG> exceeds network Sierra file size (#bytes)
    Resource <TAG> exceeds network Casm byte code size (#felts)

bytes bytes - {}",
"Warning".yellow().bold(),
stat.sierra_file_size as f64 / (1024.0 * 1024.0),
stat.sierra_file_size,
stat.tag.bright_blue()
);
}

// CASM felts check (81,920)
if stat.casm_bytecode_size > 81_920 {
eprintln!(
"{}: CASM bytecode size ({} felts) exceeds network limit of 81,920 - {}",
"Warning".yellow().bold(),
stat.casm_bytecode_size,
stat.tag.bright_blue()
);
}
}

if self.stats != StatOptions::default() {
if self.stats.sort_by_tag {
stats.sort_by_key(|s| s.tag.clone());
} else if self.stats.sort_by_sierra_mb {
Expand Down
Loading